Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💬 Remove dot from DioException.connectionError(reason) #2024

Merged
merged 1 commit into from
Nov 5, 2023
Merged

💬 Remove dot from DioException.connectionError(reason) #2024

merged 1 commit into from
Nov 5, 2023

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Nov 5, 2023

We mainly construct the exception with a complete sentence, which will produce a double . in the message.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@ueman

@AlexV525 AlexV525 requested a review from a team as a code owner November 5, 2023 11:32
ueman
ueman approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexV525 AlexV525 added this pull request to the merge queue Nov 5, 2023
Merged via the queue into main with commit 78737f2 Nov 5, 2023
30 checks passed
@AlexV525 AlexV525 deleted the chore/dio-exception-reason branch November 5, 2023 13:51
@AlexV525 AlexV525 added the e: documentation Improvements or additions to documentation label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
e: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexV525 @ueman